PYTHON-2777 Raise client side error for snapshot reads on <5.0 #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
changed the title
ShaneHarvey
commented
Jun 29, 2021
| if (self.options.causal_consistency | ||
| and self.operation_time is not None): | ||
| cmd.setdefault('readConcern', {})[ | ||
| 'afterClusterTime'] = self.operation_time | ||
| if self.options.snapshot: | ||
| if sock_info.max_wire_version < 13: | ||
| raise ConfigurationError( |
There was a problem hiding this comment.
This could be InvalidOperation or ConfigurationError. We seem to use both in this file for various "this thing is not supported" errors. Do you have a preference?
There was a problem hiding this comment.
ConfigurationError makes more sense to me.
prashantmital
approved these changes
Jun 29, 2021
ShaneHarvey
added a commit
that referenced
this pull request
Jun 29, 2021
(cherry picked from commit 4152600)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.