PYTHON-2827 Versioned API migration example for ecosystem docs #687
Conversation
| @@ -1137,6 +1137,42 @@ def test_versioned_api(self): | |||
| uri, server_api=ServerApi("1", deprecation_errors=True)) | |||
| # End Versioned API Example 4 | |||
|
|
|||
| @client_context.require_version_min(4, 7) | |||
There was a problem hiding this comment.
Do we still need to skip sharded clusters?
There was a problem hiding this comment.
The issue has been fixed in 5.0.2 - https://jira.mongodb.org/browse/SERVER-58794 but seems like we are still using 5.0. 🤔
Should I just skip it on sharded or we can wait for this to pass before merging?
There was a problem hiding this comment.
Do you mind updating drivers evergreen tools to use 5.0.2 real quick?
There was a problem hiding this comment.
How does one figure out if it is available yet? I only see 5.0.1 on m...
There was a problem hiding this comment.
Yeah its definitely not yet available.
There was a problem hiding this comment.
It's not out yet: https://docs.mongodb.com/manual/release-notes/5.0/
I suggest putting something like :
if sharded and 5.0 and <5.0.2:
self.skip()
test/test_examples.py
Outdated
|
|
||
| # Start Versioned API Example 8 | ||
| # 8 | ||
| # End Versioned API Example 7 |
There was a problem hiding this comment.
Drive-by fix. I think this typo is also in motor here.
| # End Versioned API Example 7 | |
| # End Versioned API Example 8 |
(cherry picked from commit f86b2c6)
No description provided.