PYTHON-2868 Test Serverless behind a load balancer #742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LESS_URI" This reverts commit bf8a236.
ShaneHarvey
commented
Sep 23, 2021
| client_options['username'] = db_user | ||
| client_options['password'] = db_pwd | ||
|
|
||
| return MongoClient(uri, port, **client_options) |
There was a problem hiding this comment.
These changes were required in order to support passing mongodb+srv addresses through rs_client() and friends.
| if client_context.auth_enabled: | ||
| uri = "mongodb://%s:%s@%s" % (db_user, db_pwd, encoded_socket) | ||
| else: | ||
| uri = "mongodb://%s" % encoded_socket |
There was a problem hiding this comment.
rs_or_single_client adds the username/password now.
| @@ -33,7 +33,8 @@ | |||
| class_name_prefix='UnifiedTestFormat', | |||
| expected_failures=[ | |||
| 'Client side error in command starting transaction', # PYTHON-1894 | |||
| ])) | |||
| ], | |||
| RUN_ON_SERVERLESS=False)) | |||
There was a problem hiding this comment.
The serverless testing spec doesn't say to run the unified format spec tests.
behackett
approved these changes
Sep 23, 2021
ShaneHarvey
added a commit
that referenced
this pull request
Sep 23, 2021
(cherry picked from commit 968ee7b)
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.