PYTHON-2914 MongoClient should raise an error when given multiple URIs #747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Sep 28, 2021
doc/migrate-to-pymongo4.rst
Outdated
| @@ -187,6 +187,12 @@ MongoClient cannot execute operations after ``close()`` | |||
| after being closed. The previous behavior would simply reconnect. However, | |||
| now you must create a new instance. | |||
|
|
|||
| MongoClient raises exception when given more than 1 URI | |||
pymongo/mongo_client.py
Outdated
| # Raise an error when we have more than one URI | ||
| if len([i for i in host if "/" in i]) > 1: | ||
| raise ConfigurationError("MongoClient() only accepts 1 URI at a " | ||
| "time") |
There was a problem hiding this comment.
I'd say: "host must not contain multiple MongoDB URIs"
pymongo/mongo_client.py
Outdated
| @@ -645,6 +645,10 @@ def __init__( | |||
| dbase = None | |||
| opts = common._CaseInsensitiveDictionary() | |||
| fqdn = None | |||
| # Raise an error when we have more than one URI | |||
There was a problem hiding this comment.
This comment is redundant because the error message says the same thing.
pymongo/mongo_client.py
Outdated
| @@ -645,6 +645,10 @@ def __init__( | |||
| dbase = None | |||
| opts = common._CaseInsensitiveDictionary() | |||
| fqdn = None | |||
| # Raise an error when we have more than one URI | |||
| if len([i for i in host if "/" in i]) > 1: | |||
ShaneHarvey
requested changes
Sep 29, 2021
| username, and password present will be used. For username and | ||
| a simple hostname. It can also be a list of hostnames but no more | ||
| than one URI. Any port specified in the host string(s) will override | ||
| the `port` parameter. For username and |
There was a problem hiding this comment.
We need to make a similar change to the description in the :Parameters: list below.
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 6, 2022
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.