PYTHON-2948 Add prose test for SRV polling with a custom service name #764
+18
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Oct 26, 2021
test/test_srv_polling.py
Outdated
| sleep(2*common.MIN_SRV_RESCAN_INTERVAL) | ||
| final_topology = set(client.topology_description.server_descriptions()) | ||
| self.assertIn(response[0], final_topology) | ||
| self.assertIn(response[1], final_topology) |
There was a problem hiding this comment.
We can use assert_nodelist_change instead of:
sleep(2*common.MIN_SRV_RESCAN_INTERVAL)
final_topology = set(client.topology_description.server_descriptions())
self.assertIn(response[0], final_topology)
self.assertIn(response[1], final_topology)
There was a problem hiding this comment.
Yeah I could have have sworn I tried using assert_nodelist_change and it didn't work, but I just tried it again and it does work. Done.
ShaneHarvey
requested changes
Oct 26, 2021
test/test_srv_polling.py
Outdated
| "mongodb+srv://test22.test.build.10gen.cc/?srvServiceName" | ||
| "=customname") | ||
| with SrvPollingKnobs( | ||
| dns_resolver_nodelist_response=nodelist_callback): |
There was a problem hiding this comment.
This needs to be rebased to fix the dns_resolver_nodelist_response rename in PYTHON-2832
juliusgeo
force-pushed
the
PYTHON-2948
branch
from
024c2d0 to
0a17e60
Compare
ShaneHarvey
approved these changes
Oct 26, 2021
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.