PYTHON-2164 Remove client max_bson_size/max_message_size/max_write_batch_size #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tch_size
Use the hello command instead:
doc = client.admin.command('hello')
max_bson_size = doc['maxBsonObjectSize']
max_message_size = doc['maxMessageSizeBytes']
max_write_batch_size = doc['maxWriteBatchSize']
behackett
requested changes
Oct 27, 2021
| @@ -173,6 +173,27 @@ can be changed to this:: | |||
|
|
|||
| names = client.list_database_names() | |||
|
|
|||
| MongoClient.max_bson_size/max_message_size/max_write_batch_size are removed | |||
There was a problem hiding this comment.
Explain why we're removing them.
There was a problem hiding this comment.
Done. Waiting for the tests to pass.
…ology and run server selection
ShaneHarvey
commented
Oct 27, 2021
| return [s for s in selection.server_descriptions | ||
| if (s.round_trip_time - fastest) <= threshold] | ||
|
|
||
| def apply_selector(self, selector, address=None, custom_selector=None): |
There was a problem hiding this comment.
This is a minor quality improvement. The method was already "public" I just added docs and refactored apply_local_threshold to be a method instead of an inline function.
pymongo/mongo_client.py
Outdated
| @@ -937,16 +937,16 @@ def address(self): | |||
|
|
|||
| .. versionadded:: 3.0 | |||
| """ | |||
| topology_type = self._topology._description.topology_type | |||
| # Block until we discover the topology type. | |||
There was a problem hiding this comment.
This was a minor bug exposed by one of the test changes. The bug was that client.address on a connect=False client would not open the topology as the documentation suggests:
If the client is not connected, this will block until a connection is
established or raise ServerSelectionTimeoutError if no server is
available.
This fix is to attempt server selection once before doing the topology_type/primary checks. I don't think it's worth backporting to v3.
… the topology and run server selection" This reverts commit ffb340b.
ShaneHarvey
requested review from
julianedwards and
juliusgeo
and removed request for
julianedwards
|
@behackett did you want to review this again? |
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
…tch_size (mongodb#766) Use the hello command instead: doc = client.admin.command('hello') max_bson_size = doc['maxBsonObjectSize'] max_message_size = doc['maxMessageSizeBytes'] max_write_batch_size = doc['maxWriteBatchSize'] Also add documentation for TopologyDescription.apply_selector.
juliusgeo
pushed a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
…tch_size (mongodb#766) Use the hello command instead: doc = client.admin.command('hello') max_bson_size = doc['maxBsonObjectSize'] max_message_size = doc['maxMessageSizeBytes'] max_write_batch_size = doc['maxWriteBatchSize'] Also add documentation for TopologyDescription.apply_selector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apps should use the hello command instead:
I'll address the remaining configuration attributes (max_pool_size, min_pool_size, max_idle_time_ms, local_threshold_ms, server_selection_timeout, etc.) in a new PR.