PYTHON-3014 Update how events are added to entity map to match specification #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Nov 12, 2021
| @@ -226,7 +226,10 @@ def add_event(self, event): | |||
| if event_name in self._event_types: | |||
| super(EventListenerUtil, self).add_event(event) | |||
| for id in self._event_mapping[event_name]: | |||
| self.entity_map[id].append(str(event)) | |||
| self.entity_map[id].append({ | |||
| "name": type(event).__name__, | |||
There was a problem hiding this comment.
repr(event) is better than just the type name because it includes the event name and other additional info (see the __repr__ methods in monitoring.py).
There was a problem hiding this comment.
I originally had it just use str(event). However,
if ('name' not in event) or (not event['name'].endswith('Event')):
self.fail("The workload executor didn't record event name as expected.")
This line from validator.py in drivers-atlas-testing seems to indicate that it expects it to just have the name, and no additional information
There was a problem hiding this comment.
Okay, in that case can we add a new field for the full event repr?
|
Please fix these issues as well: test_create_entities is opening clients and never closes them. |
ShaneHarvey
approved these changes
Nov 12, 2021
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.