PYTHON-1489 Merge ajdavis/pymongo-mockup-tests into pymongo #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
reviewed
Nov 12, 2021
.evergreen/run-mockupdb-tests.sh
Outdated
| @@ -15,6 +15,5 @@ trap "deactivatei, rm -rf mockuptests" EXIT HUP | |||
| # download it from pypi. | |||
| python -m pip install ${PROJECT_DIRECTORY} | |||
|
|
|||
| git clone https://github.com/ajdavis/pymongo-mockup-tests.git | |||
| cd pymongo-mockup-tests | |||
| cd ../test/mockupdb | |||
| python setup.py test | |||
There was a problem hiding this comment.
I'm confused how this works. The script does this:
cd ..
cd ../test/mockupdb
python setup.py test
- We don't need to cd at all, the venv can live in the working dir.
- Don't we have to install the mockup tests requirements?
- I don't think we can use setup.py. Instead we should use "-m unittest discover ..." to run only the tests in the
test/mockupdbdirectory.
ShaneHarvey
requested changes
Nov 12, 2021
test/mockupdb/__init__.py
Outdated
| @@ -0,0 +1,20 @@ | |||
| # Copyright 2015 MongoDB, Inc. | |||
There was a problem hiding this comment.
You'll notice that the test suite is failing because pytohn setup.py test attempts to run tests in this directory. We can fix that problem by removing this init file.
ShaneHarvey
requested changes
Nov 16, 2021
.evergreen/run-mockupdb-tests.sh
Outdated
| . .evergreen/utils.sh | ||
|
|
||
| ${PYTHON_BINARY} setup.py clean | ||
| cd .. | ||
|
|
||
| createvirtualenv ${PYTHON_BINARY} mockuptests | ||
| trap "deactivatei, rm -rf mockuptests" EXIT HUP |
There was a problem hiding this comment.
let's fix this typo: deactivatei
.evergreen/run-mockupdb-tests.sh
Outdated
| @@ -2,19 +2,17 @@ | |||
|
|
|||
| set -o xtrace | |||
| set -o errexit | |||
|
|
|||
| cd $PROJECT_DIRECTORY | |||
There was a problem hiding this comment.
Ideally we can run this script locally with no setup. Let's define PROJECT_DIRECTORY ourselves:
PROJECT_DIRECTORY=$(dirname $(dirname $0))
.evergreen/run-mockupdb-tests.sh
Outdated
| git clone https://github.com/ajdavis/pymongo-mockup-tests.git | ||
| cd pymongo-mockup-tests | ||
| python setup.py test | ||
| python -m pip install mockupdb |
There was a problem hiding this comment.
The old tests install mockupdb@master. Let's do the same here:
python -m pip install --upgrade 'https://github.com/ajdavis/mongo-mockup-db/archive/master.zip'
.evergreen/run-mockupdb-tests.sh
Outdated
| python setup.py test | ||
| python -m pip install mockupdb | ||
| cd ${PROJECT_DIRECTORY}/test/mockupdb | ||
| python -m unittest discover |
There was a problem hiding this comment.
Please add the -v flag as I suggested earlier.
| from pymongo import MongoClient | ||
|
|
||
| import unittest | ||
| from test.operations import upgrades |
|
You've accidentally committed the virtualenv directory. Please remove it. |
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 5, 2022
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 6, 2022
juliusgeo
added a commit
to juliusgeo/mongo-python-driver
that referenced
this pull request
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.