Skip to content

PYTHON-3005 Make maxConnecting configurable #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 16, 2021

Conversation

ShaneHarvey
Copy link
Member

No description provided.

Copy link
Member

@behackett behackett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the existing code for limiting the number of concurrent connection attempts, it's almost like you expected this to become a configurable. :-)

@@ -184,7 +184,8 @@ Notable improvements
....................

- Enhanced connection pooling to create connections more efficiently and
avoid connection storms.
avoid connection storms. Added the ``maxConnecting`` URI and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know these two things are related, but I would suggest making them separate bullet points.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member Author

@ShaneHarvey ShaneHarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for another look.

IIRC when I implemented this we were still discussing whether to make it configurable or not.

@@ -184,7 +184,8 @@ Notable improvements
....................

- Enhanced connection pooling to create connections more efficiently and
avoid connection storms.
avoid connection storms. Added the ``maxConnecting`` URI and
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@behackett
Copy link
Member

Still looks good to me.

@ShaneHarvey ShaneHarvey merged commit 278a50d into mongodb:master Nov 16, 2021
juliusgeo pushed a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 5, 2022
juliusgeo pushed a commit to juliusgeo/mongo-python-driver that referenced this pull request Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants