-
Notifications
You must be signed in to change notification settings - Fork 1.1k
PYTHON-3005 Make maxConnecting configurable #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the existing code for limiting the number of concurrent connection attempts, it's almost like you expected this to become a configurable. :-)
doc/changelog.rst
Outdated
@@ -184,7 +184,8 @@ Notable improvements | |||
.................... | |||
|
|||
- Enhanced connection pooling to create connections more efficiently and | |||
avoid connection storms. | |||
avoid connection storms. Added the ``maxConnecting`` URI and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know these two things are related, but I would suggest making them separate bullet points.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready for another look.
IIRC when I implemented this we were still discussing whether to make it configurable or not.
doc/changelog.rst
Outdated
@@ -184,7 +184,8 @@ Notable improvements | |||
.................... | |||
|
|||
- Enhanced connection pooling to create connections more efficiently and | |||
avoid connection storms. | |||
avoid connection storms. Added the ``maxConnecting`` URI and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Still looks good to me. |
No description provided.