PYTHON-2850 [v3.13] Deprecate mapReduce command #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusgeo
changed the title
|
Can you please add a version changed entry for both methods as well? |
behackett
requested changes
Feb 10, 2022
pymongo/collection.py
Outdated
| @@ -3091,6 +3093,10 @@ def map_reduce(self, map, reduce, out, full_response=False, session=None, **kwar | |||
| this collection is automatically applied to this operation (if the | |||
| output is not inline) when using MongoDB >= 3.4. | |||
|
|
|||
| .. versionchanged:: 3.13 | |||
| Deprecated :meth:`map_reduce`. Support for this function is deprecated in | |||
There was a problem hiding this comment.
We should also say that this is removed in PyMongo 4.0:
https://pymongo.readthedocs.io/en/stable/migrate-to-pymongo4.html#collection-map-reduce-and-collection-inline-map-reduce-are-removed
You should say here what users should do instead. An abbreviated version of what the PyMongo 4 upgrade guide says.
pymongo/collection.py
Outdated
| @@ -3153,11 +3163,16 @@ def inline_map_reduce(self, map, reduce, full_response=False, session=None, **kw | |||
|
|
|||
| >>> db.test.inline_map_reduce(map, reduce, limit=2) | |||
|
|
|||
| .. versionchanged:: 3.13 | |||
| Deprecated :meth:`inline_map_reduce`. Support for this function is deprecated in | |||
juliusgeo
force-pushed
the
PYTHON-2850-313
branch
from
5aaeea7 to
08743fd
Compare
|
Managed to accidentally merge with master rather than the v3.13 branch so there are a tonnn of messed up changes. I think I'm just gonna create this from scratch in a new PR given how small it is. |
juliusgeo
force-pushed
the
PYTHON-2850-313
branch
from
08743fd to
a8e20ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate mapReduce helpers