PYTHON-3119 getMore helper should explicitly send inherited comment #904
Conversation
| @@ -15,3 +15,4 @@ pymongo.egg-info/ | |||
| .tox | |||
| mongocryptd.pid | |||
| .idea/ | |||
| .nova/ | |||
There was a problem hiding this comment.
It is for my IDE. I can add it to my .git/info/exclude file if you'd rather not add it to the repository .gitignore.
There was a problem hiding this comment.
It's fine here, I'm curious what IDE?
There was a problem hiding this comment.
Nova--it's by the same people who made the FTP client Transfer.
test/test_monitoring.py
Outdated
| @@ -239,6 +239,7 @@ def _test_find_options(self, query, expected_cmd): | |||
| # Exhaust the cursor to avoid kill cursors. | |||
| tuple(cursor) | |||
|
|
|||
| @client_context.require_version_min(4, 4, 4) | |||
There was a problem hiding this comment.
"Comment" is not supported on "getMore" commands below 4.4.4 IIUC
There was a problem hiding this comment.
Doesn't that make this PR a major breaking change?
There was a problem hiding this comment.
I checked the getMore docs and it appears that comment is not supported below 4.4.4. So yes, this would be a major breaking change.
| @@ -15,3 +15,4 @@ pymongo.egg-info/ | |||
| .tox | |||
| mongocryptd.pid | |||
| .idea/ | |||
| .nova/ | |||
There was a problem hiding this comment.
It's fine here, I'm curious what IDE?
test/test_monitoring.py
Outdated
| @@ -239,6 +239,7 @@ def _test_find_options(self, query, expected_cmd): | |||
| # Exhaust the cursor to avoid kill cursors. | |||
| tuple(cursor) | |||
|
|
|||
| @client_context.require_version_min(4, 4, 4) | |||
There was a problem hiding this comment.
Doesn't that make this PR a major breaking change?
|
Changes LGTM so far. Can you resync the tests from mongodb/specifications#1161 too? |
No description provided.