PYTHON-3227 Clustered Indexes for all Collections #971
Conversation
test/unified_format.py
Outdated
| self.test.assertIsInstance(actual, abc.MutableSequence) | ||
|
|
||
| self.test.assertIsInstance( | ||
| actual, (abc.MutableSequence, pymongo.command_cursor.CommandCursor) |
There was a problem hiding this comment.
This is necessary because list_indexes returns a CommandCursor, not a MutableSequence like expected. We do not seem to test the type of the output of list_indexes elsewhere in the spec tests, and in the pymongo specific tests we always convert to list immediately.
There was a problem hiding this comment.
Let's return a list from _collectionOperation_listIndexes instead. That's what we do for find and listCollections.
| name: <string>, // optional, otherwise automatically generated | ||
| v: <int>, // optional, must be ‘2’ if provided | ||
| } | ||
|
|
||
| - `**kwargs` (optional): additional keyword arguments will | ||
| be passed as options for the `create collection command`_ |
There was a problem hiding this comment.
Given this description of kwargs, I wonder if it would be more consistent to not add an explicit "clustered_index" parameter and instead document clusteredIndex as an acceptable kwarg below. If so, we probably do the same for encrypted_fields.
We would make the same change to Collection.
test/unified_format.py
Outdated
| self.test.assertIsInstance(actual, abc.MutableSequence) | ||
|
|
||
| self.test.assertIsInstance( | ||
| actual, (abc.MutableSequence, pymongo.command_cursor.CommandCursor) |
There was a problem hiding this comment.
Let's return a list from _collectionOperation_listIndexes instead. That's what we do for find and listCollections.
pymongo/database.py
Outdated
| - `**kwargs` (optional): additional keyword arguments will | ||
| be passed as options for the `create collection command`_ | ||
| Examples of valid |
pymongo/collection.py
Outdated
| name: <string>, // optional, otherwise automatically generated | ||
| v: <int>, // optional, must be ‘2’ if provided | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's remove this section to avoid duplicating the docs. We already document encryptedFields/clusteredIndex and other options in create_collection and instantiating a Collection directly is uncommon.
|
@juliusgeo you picked up a merge conflict |
No description provided.