PYTHON-3297 Test auto decryption occurs after CommandSucceeded events #980
Conversation
test/test_encryption.py
Outdated
| # /README.rst#14-decryption-events | ||
| class TestDecryptProse(EncryptionIntegrationTest): | ||
| def setUp(self): | ||
| self.setup_client = MongoClient() |
There was a problem hiding this comment.
We should use self.client (same as client_context.client) instead of creating a new client here. Otherwise the test will fail on auth or tls.
There was a problem hiding this comment.
This is not done. Please re-read my comment.
test/test_encryption.py
Outdated
| self.addCleanup(self.encrypted_client.close) | ||
|
|
||
| def test_command_error(self): | ||
| self.setup_client.admin.command( |
There was a problem hiding this comment.
We should use the with self.fail_point(...) helper since it always disables the failpoint.
There was a problem hiding this comment.
FYI you can put multiple context managers in one with-statement. So this:
with self.fail_point(...):
with self.assertRaises(...):
passCan be written as:
with self.fail_point(...), self.assertRaises(...):
passNo need to change anything though.
| i = self.listener.results["succeeded"][0] | ||
| self.assertEqual( | ||
| i.reply["cursor"]["firstBatch"][0]["encrypted"], self.malformed_cipher_text | ||
| ) |
There was a problem hiding this comment.
I know the spec doesn't say to but it would be good to assert there are 0 failed events.
| i = self.listener.results["succeeded"][0] | ||
| self.assertEqual( | ||
| i.reply["cursor"]["firstBatch"][0]["encrypted"], self.malformed_cipher_text | ||
| ) |
test/test_encryption.py
Outdated
| # /README.rst#14-decryption-events | ||
| class TestDecryptProse(EncryptionIntegrationTest): | ||
| def setUp(self): | ||
| self.setup_client = MongoClient() |
There was a problem hiding this comment.
This is not done. Please re-read my comment.
test/test_encryption.py
Outdated
| self.addCleanup(self.encrypted_client.close) | ||
|
|
||
| def test_command_error(self): | ||
| self.setup_client.admin.command( |
There was a problem hiding this comment.
FYI you can put multiple context managers in one with-statement. So this:
with self.fail_point(...):
with self.assertRaises(...):
passCan be written as:
with self.fail_point(...), self.assertRaises(...):
passNo need to change anything though.
No description provided.