Skip to content

AutoReconnect error should be raised instead of TypeError when ReadPrefrence.SECONDARY is used #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

AutoReconnect error should be raised instead of TypeError when ReadPrefrence.SECONDARY is used #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pymongo/replica_set_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ def _send_message_with_response(self, msg, _connection_to_use=None,
except AutoReconnect, why:
self.disconnect()
errors.append(why)
raise AutoReconnect(', '.join(errors))
raise AutoReconnect(', '.join(map(str, errors)))

def __cmp__(self, other):
# XXX: Implement this?
Expand Down
9 changes: 9 additions & 0 deletions test/test_replica_set_connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@

from bson.son import SON
from bson.tz_util import utc
from mock import Mock, patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new dependancy, can you confirm which mocking library this is?

from pymongo import ReadPreference
from pymongo.connection import Connection
from pymongo.replica_set_connection import ReplicaSetConnection
Expand Down Expand Up @@ -157,6 +158,14 @@ def make_db(base, name):
self.assertEqual(connection.test, Database(connection, "test"))
connection.close()

def test_auto_reconnect_exception_when_read_preference_is_secondary(self):
c = self._get_connection()
db = c.pymongo_test

with patch('socket.socket.sendall', Mock(side_effect=socket.error)):
cursor = db.test.find(read_preference=ReadPreference.SECONDARY)
self.assertRaises(AutoReconnect, cursor.next)

def test_operations(self):
c = self._get_connection()

Expand Down