PYTHON-2986 Update serverless testing for load balancer fronting single proxy #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaneHarvey
requested changes
Jul 6, 2022
.evergreen/config.yml
Outdated
| export SERVERLESS_ATLAS_USER="${SERVERLESS_ATLAS_USER}" | ||
| export SERVERLESS_ATLAS_PASSWORD="${SERVERLESS_ATLAS_PASSWORD}" | ||
| export SINGLE_MONGOS_LB_URI="${SINGLE_ATLASPROXY_SERVERLESS_URI}" | ||
| export MULTI_MONGOS_LB_URI="${MULTI_ATLASPROXY_SERVERLESS_URI}" | ||
| export MONGODB_URI="mongodb+srv://${SERVERLESS_ATLAS_USER}:${SERVERLESS_ATLAS_PASSWORD}@${SERVERLESS_URI:14}" |
There was a problem hiding this comment.
We don't need to add the credentials to the MONGODB_URI since the user/pass are already configured:
mongo-python-driver/.evergreen/run-tests.sh
Lines 48 to 50 in 154d878
It will be more robust if we do export MONGODB_URI="${SERVERLESS_URI}" since SERVERLESS_URI:14 will break if the uri format changes.
ShaneHarvey
approved these changes
Jul 6, 2022
|
Remaining errors are CSOT-related |
blink1073
added a commit
to blink1073/mongo-python-driver
that referenced
this pull request
Oct 21, 2022
…le proxy (mongodb#997) (cherry picked from commit ff1efd1)
blink1073
added a commit
that referenced
this pull request
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.