RUST-2203 Allow client metadata to be appended post-construction #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Sep 15, 2025
| @@ -656,6 +656,9 @@ pub(crate) struct TestOptions { | |||
|
|
|||
| /// Async-capable command event listener. | |||
| pub(crate) async_event_listener: Option<TestEventSender>, | |||
|
|
|||
| /// Callback to receive hello commands. | |||
| pub(crate) hello_cb: Option<EventHandler<crate::cmap::Command>>, | |||
There was a problem hiding this comment.
The prose tests required direct visibility of hello commands, so new test hook. I used EventHandler for this because that's easier than typing Arc<Box<dyn Fn(crate::cmap::Command)>> all over the place and it already implements things like Debug.
| @@ -48,12 +48,12 @@ pub(crate) struct EstablisherOptions { | |||
| pub(crate) test_patch_reply: Option<fn(&mut Result<HelloReply>)>, | |||
| } | |||
|
|
|||
| impl From<&ClientOptions> for EstablisherOptions { | |||
| fn from(opts: &ClientOptions) -> Self { | |||
| impl From<&TopologySpec> for EstablisherOptions { | |||
There was a problem hiding this comment.
Because Establisher / Handshaker now require a value outside of ClientOptions to construct, I introduced TopologySpec to capture that (and anything similar that happens to be needed in the future) rather than thread through another function parameter.
src/cmap/establish/handshake/test.rs
Outdated
There was a problem hiding this comment.
These were just construction tests of metadata values and IMO didn't have enough utility to be worth updating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2203 / RUST-2272
This required moving metadata from something that each worker has its own copy of to a central per-
Client(actually per-Topology) shared value.I initially implemented this as an update that gets fanned out to the workers using the existing infrastructure that's there for shutdown and the like; that turned out to require a centralized copy anyway so I dropped the fan-out. In the process, though, I did some refactoring of the related methods so that worker commands require fewer intermediate pass-through wrapper methods and division of logic among the components is clearer.