RUST-1405 Expose full server response in Error
#1474
Conversation
isabelatkinson
force-pushed
the
raw-result
branch
from
3d372dc to
e4a03f1
Compare
src/error.rs
Outdated
| #[source] | ||
| pub(crate) source: Option<Box<Error>>, | ||
|
|
||
| pub(crate) server_response: Option<Box<Document>>, |
There was a problem hiding this comment.
I'd lean towards storing and exposing this as a RawDocumentBuf - this feels like a "lower level" API where the wire representation is more appropriate, and also it allows inspecting the bytes in case the server sends a response that doesn't fully parse.
There was a problem hiding this comment.
Agreed - I updated this to be a raw document. I did leave the tracing representation to be a parsed document for readability in logs (https://github.com/mongodb/specifications/blob/master/source/logging/logging.md#representing-documents-in-log-messages) with a hex string of the byte vec as a fallback.
| fn tracing_representation(&self) -> String { | ||
| self.to_string() | ||
| impl crate::error::Error { | ||
| fn tracing_representation(&self, max_document_length: usize) -> String { |
There was a problem hiding this comment.
Having to feature-conditionally thread this through everywhere is a bit unpleasant; what would you think about attaching max_document_length as a field of Error instead?
There was a problem hiding this comment.
I prefer this approach as it'll accommodate any future additions of fields needing truncation for the conection and SDAM emitters, and it feels consistent with other fields for the command emitter - happy to make the change if you feel strongly in the other direction, though
isabelatkinson
force-pushed
the
raw-result
branch
from
6f0e91b to
7f3a4c3
Compare
RUST-1405