RUST-2127 lint for sign loss when casting #1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Sep 29, 2025
| } | ||
|
|
||
| #[allow(private_bounds)] | ||
| pub(crate) fn round_clamp<T: RoundClampTarget>(input: f64) -> T { |
There was a problem hiding this comment.
Doing it this way allows the type to be specified inline with the call rather than the awkwardness that Into and friends have.
| } | ||
| } | ||
|
|
||
| pub(crate) mod option_u64_as_i64 { |
There was a problem hiding this comment.
This could be just bson::serde_helpers::u64::AsI64 but we can't rely on bson 3.0 stuff :(
abr-egn
force-pushed
the
RUST-2127/lint-cast-sign-loss
branch
from
21098b0 to
0c190d8
Compare
isabelatkinson
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2127
This enables the
clippy::cast_sign_losslint and fixes all the locations it flagged. These fell into four fuzzy categories:try_into().unwrap()so if the checks miss something it'll cause a panic rather than silent misbehavior;as) to make it clear that's what's intended;try_into().unwrap()