RUST-2113 Add has_next to cursor API #1485
Merged
+48
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/cursor.rs
Outdated
Comment on lines
231
to
234
| /// Returns true if the cursor has any additional buffered items to return and false otherwise. | ||
| /// | ||
| /// This method only checks the local buffer and exhaustion state; it does not contact the | ||
| /// server. |
There was a problem hiding this comment.
Suggested change
| /// Returns true if the cursor has any additional buffered items to return and false otherwise. | |
| /// | |
| /// This method only checks the local buffer and exhaustion state; it does not contact the | |
| /// server. | |
| /// Returns true if the cursor has any additional items to return and false otherwise. |
The call to is_exhausted checks whether the server has more batches based on its last getMore response, so the "buffered" distinction isn't necessary here.
(ditto for the doc on the sync method)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1258
has_next()pub + added doc commentshas_next()to sync cursor API