minor: remove unused variables #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghm
force-pushed
the
remove-unused-variables
branch
from
ea2a5a7 to
174de2b
Compare
saghm
commented
Jun 24, 2020
| @@ -55,13 +52,13 @@ impl Monitor { | |||
| .heartbeat_freq | |||
| .unwrap_or(DEFAULT_HEARTBEAT_FREQUENCY); | |||
|
|
|||
| while let Some(server) = self.server.upgrade() { | |||
| while let Some(_server) = self.server.upgrade() { | |||
There was a problem hiding this comment.
We want to make sure we can upgrade the weak reference to the server to a strong reference, since being unable to indicates that the server was dropped from the cluster, but we don't actually need the server itself for the body of the loop.
| @@ -254,8 +254,6 @@ impl Topology { | |||
| // references to the same instances though, since each is wrapped in an `Arc`. | |||
| let mut state_clone = self.state.read().await.clone(); | |||
|
|
|||
| let old_description = state_clone.description.clone(); | |||
There was a problem hiding this comment.
We call update_state to do the work of replacing the topology state, which handles replacing the description and starting the new monitoring threads without needing the old description, so this dead code doesn't represent any missing logic, but rather an unnecessary variable.
isabelatkinson
approved these changes
Jun 24, 2020
patrickfreed
approved these changes
Jun 24, 2020
utkmehta
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that we accidentally never removed the project-wide annotation to suppress unused variable warnings, so I removed it and fixed all the issues. Fortunately, almost all of these were not indicators of bugs; the one exception was a very minor bug in handshake metadata logic for libraries wrapping the driver, where we accidentally appended the platform name to the driver's version string instead of the platform string (but with the proper delimiter, so this likely didn't break anything).