RUST-483 Allow alternate DNS resolver configs #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saghm
approved these changes
Jul 22, 2020
isabelatkinson
approved these changes
Jul 22, 2020
README.md
Outdated
| @@ -182,6 +184,21 @@ for result in cursor { | |||
|
|
|||
| Currently, the driver has issues connecting to Atlas tiers above M2 unless the server version is at least 4.2. We're working on fixing this, but in the meantime, a workaround is to upgrade your cluster to 4.2. The driver has no known issues with either M0 or M2 instances. | |||
|
|
|||
| ## Windows DNS note | |||
|
|
|||
| On Windows, there is a known issue in the `trust-dns-resolver` crate, which the driver uses to perform DNS lookups, that causes severe performance degradation in resolvers that use the system configuration. Since the driver uses the system configuration by default, users are recommended to specify an alternate resolver configuration on Windows until that issue is resolved. This is only has an effect when connecting to deployments using a `mongodb+srv` connection string. | |||
There was a problem hiding this comment.
there's an extraneous "is" at the beginning of the last sentence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-483
This PR allows users to resolve
mongodb+srvconnection strings using alternate DNS resolver configurations. This helps users avoid the known performance issue in trust-dns-resolver on Windows when using the system configuration (issue seen in RUST-467).I opted to only include a helper on
ClientOptionsand not one onClientitself since this seemed like a very specific issue that was strictly configuration related.