Skip to content

RUST-696 Update optional dependencies #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 25, 2021
Merged

RUST-696 Update optional dependencies #308

merged 1 commit into from
Mar 25, 2021

Conversation

saghm
Copy link
Contributor

@saghm saghm commented Mar 24, 2021

No description provided.

@saghm saghm force-pushed the optional-dependencies branch from 15d5142 to 787d02d Compare March 24, 2021 20:54
isabelatkinson
isabelatkinson reviewed Mar 24, 2021
View reviewed changes
Copy link
Contributor

@isabelatkinson isabelatkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM. It looks like there's a failure on AWS 4.4 in CI, although I can't discern from the logs what actually failed. Is that just an evergreen fluke?

@saghm
Copy link
Contributor Author

saghm commented Mar 25, 2021

I'm not sure what happened with the AWS tests before, but after a rebase they seem fine

@saghm saghm merged commit dba1265 into mongodb:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isabelatkinson isabelatkinson isabelatkinson approved these changes

+1 more reviewer

@patrickfreed patrickfreed patrickfreed approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saghm @patrickfreed @isabelatkinson