RUST-697 / RUST-701 Add sessions and transactions to unified test runner #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NBSquare
force-pushed
the
RUST-697
branch
2 times, most recently
from
6706b47 to
91d2528
Compare
isabelatkinson
approved these changes
Jun 25, 2021
abr-egn
reviewed
Jun 25, 2021
| #[derive(Clone, Debug)] | ||
| pub struct SessionEntity { | ||
| pub lsid: Document, | ||
| pub client_session: Option<Box<ClientSession>>, |
There was a problem hiding this comment.
I'm not sure why the ClientSession is boxed here?
There was a problem hiding this comment.
Clippy errors without the box, since the struct is too large otherwise.
Should I suppress the linter error instead?
There was a problem hiding this comment.
Oh in that case its probably just fine to keep the Box then imo.
There was a problem hiding this comment.
Changes look great to me, just echoing @abr-egn's question about the boxed session.
patrickfreed
approved these changes
Jun 25, 2021
abr-egn
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As above. Implemented a new unified test runner entity which wraps on a
ClientSessionand on its LSID, so that when the session is dropped, the LSID persists in the entity map to cross-reference with expected events.Currently skipping one test in
poc-transactionsbecause it relies on index management, which isn't implemented AFAIK.