Update all library and tooling dependencies #678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmahar
commented
Sep 28, 2021
| let client = try MongoClient(using: elg) | ||
| try client.syncClose() | ||
| expect(try client.listDatabases().wait()).to(throwError(errorType: ChannelError.self)) | ||
| expect(try client.listDatabases().wait()).to(throwError(errorType: NIOThreadPoolError.ThreadPoolInactive.self)) |
There was a problem hiding this comment.
NIO changed the error type thrown here in a recent release.
| // ).map { $0.1 } | ||
| // let testRunner = try UnifiedTestRunner() | ||
| // try testRunner.runFiles(tests) | ||
| // let tests = try retrieveSpecTestFiles( |
There was a problem hiding this comment.
SwiftFormat update starting formatting this a little differently.
coincidentally, we can unskip this pretty soon, when Isabel picks up SWIFT-560.
patrickfreed
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the dependency versions in our Package.resolved file for NIO and the BSON library, and also the versions of the various tools we use on Evergreen.