-
Notifications
You must be signed in to change notification settings - Fork 11
DAG-1940 Generate tasks separately for Windows, MacOS, Linux distro groups #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DAG-1940 Generate tasks separately for Windows, MacOS, Linux distro groups #43
Conversation
Are we going to open another PR to fix uneven workloads? How does task splitting generate workloads with this change? |
One of the reasons that tasks was split unevenly is that before these changes tasks were split based on historic runtime information from one of the build variants that runs the task. It turned out that on some buildvariants some of the tests are running significantly longer than on other buildvariants, but with the different ratio than the other tests, e.g. runtimes can be like So if we split task based on macos historic data, it will be unevenly split for linux and windows. Ideally we should split per each buildvariant historic data, but it will dramatically increase the version_gen task runtime. That's why we decided to split differently on major platforms. I ran a patch build with these changes. The results are not perfect, but better than before: To make it better we also need to update the splitting algorithm itself: mongo-task-generator/src/task_types/resmoke_tasks.rs Lines 434 to 470 in 0babc64
I didn't want to do this as part of this ticket. I will file another DAG ticket to update the splitting algorithm. |
evergreen merge |
After these changes a version generation for mongodb-mongo-master project has increased from ~337 sec to ~372 secs on my local machine:
Currently in evergreen it generates the version in ~143 seconds:
https://evergreen.mongodb.com/task_log_raw/mongodb_mongo_master_generate_tasks_for_version_version_gen_99286ff7b1f837df8449ef990b881c3ed1e3a64b_22_08_01_04_38_52/0?type=T#L915