DAG-1963 get the correct suite file in burn_in for non-generated tasks #44
Conversation
guoyr
requested review from
a team,
zamj and
MikhailShchatko
and removed request for
a team
src/task_types/burn_in_tests.rs
Outdated
| let mut params = self | ||
| .config_extraction_service | ||
| .task_def_to_resmoke_params(task_def, false, None)?; | ||
|
|
| } | ||
| } else { | ||
| remove_gen_suffix(&task.name) | ||
| generated_task_name |
There was a problem hiding this comment.
Can we add some tests for these updates?
| } else { | ||
| None | ||
| } | ||
| } |
There was a problem hiding this comment.
And some tests for this as well
There was a problem hiding this comment.
For this function, my thought was to have it be internal to this module. Since we don't need to mock out functions as much in this project (and rely instead more heavily on traits), the 2 tests added for find_suite_name should catch any visible changes to this function. Please feel free to push back
src/evergreen_names.rs
Outdated
| pub const GENERATE_RESMOKE_TASKS: &str = "generate resmoke tasks"; | ||
|
|
||
| // Functions for running tests. | ||
| pub const RUN_RESMOKE_TASK: &str = "run tests"; |
There was a problem hiding this comment.
Seems confusing. Maybe rename it to RUN_RESMOKE_TESTS or just RUN_TESTS?
There was a problem hiding this comment.
Changed to RUN_TEST_TESTS. Adding some comments for posterity.
I'm a bit ambivalent about the naming. Conceptually, I think this function is both parallel to _gen tasks and downstream from them by being the generated task.
For the purposes of task generation logic in this codebase, including burn_in, we treat existing instances of this function as a part of the input for task generation, which means it's treated as an equal to the _gen task definitions. I therefore named it similar to generate_resmoke_tasks to avoid potential confusion of handling "generate_resmoke_tasks" and "run_tests" the same way.
| } else { | ||
| None | ||
| } | ||
| } |
src/evergreen/evg_config_utils.rs
Outdated
| #[test] | ||
| fn test_find_suite_name_should_use_task_name_for_non_generated_task_if_no_var() { | ||
| let evg_task = EvgTask { | ||
| name: "my_task_gen".to_string(), |
There was a problem hiding this comment.
[nit] I think this should be my_task as it's not a gen task
|
evergreen merge |
ghost
merged commit 
No description provided.