DAG-1986 Distribute tests without historic runtime data evenly between subsuites #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikhailShchatko
requested review from
a team and
zamj
and removed request for
a team
MikhailShchatko
commented
Aug 19, 2022
| let origin_suite = multiversion_name.unwrap_or(¶ms.suite_name); | ||
| let test_list = self.get_test_list(params, multiversion_name)?; | ||
| let required_stats_count = percent_of_tests(test_list.len(), REQUIRED_STATS_THRESHOLD); | ||
| if task_stats.test_map.len() < required_stats_count { |
There was a problem hiding this comment.
Since we are distributing tests without historic runtime data after we have processed test with historic data, we don't need this special logic anymore.
zituo-jin
reviewed
Aug 19, 2022
| running_tests[min_idx].push(test.clone()); | ||
| } | ||
|
|
||
| for (i, test) in left_tests.iter().enumerate() { |
There was a problem hiding this comment.
Should we start at the running_tests with the minimal sum of run time when we start processing left_tests?
zituo-jin
reviewed
Aug 19, 2022
src/task_types/resmoke_tasks.rs
Outdated
| } | ||
|
|
||
| for (i, test) in left_tests.iter().enumerate() { | ||
| running_tests[i % max_tasks].push(test.clone()); |
There was a problem hiding this comment.
For the index, something like (index_minimal_sum_run_time_before_this_loop + i) % max_tasks.
zituo-jin
approved these changes
Aug 19, 2022
|
evergreen merge |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up change after DAG-1967.
Evergreen patch: https://spruce.mongodb.com/version/62ff60ea2fbabe6d0b390036/task-duration?duration=DESC
Evergreen patch nightly: https://spruce.mongodb.com/version/62ff60f1e3c33116292f43ea/task-duration?duration=DESC