DAG-1992 Generate only burn_in tasks when --burn-in is passed #47
Conversation
MikhailShchatko
requested review from
a team,
zituo-jin and
zamj
and removed request for
a team
MikhailShchatko
force-pushed
the
DAG-1992
branch
2 times, most recently
from
a161ae1 to
9bfe93c
Compare
MikhailShchatko
force-pushed
the
DAG-1992
branch
from
9bfe93c to
0e294ee
Compare
|
Example of patch where burn_in and other tasks are generated separately: https://spruce.mongodb.com/version/6308dc350305b95cf9de852b Note: It is not allowed to use generate.tasks more than once in a single evergreen task. |
| // handle them. | ||
| if task.name == BURN_IN_TESTS { | ||
| if self.gen_burn_in { | ||
| if self.gen_burn_in { |
There was a problem hiding this comment.
Can you add some tests for this logic to make sure we're skipping the tasks when we should be?
There was a problem hiding this comment.
This particular function seems hard to test or split. I've added end-to-end test for this logic.
Also added a comment to make it more clear:
https://github.com/mongodb/mongo-task-generator/pull/47/files#diff-7ff815b68943f08bef79f083c09e55ca8c18db8e25033034b12fa31f1d43dab4R64-R65
Let me know if you have better ideas.
|
We should update the docs as well for this option |
docs/generating_tasks.md
Outdated
| task to the required buildvariant, that will generate another required buildvariants on the fly | ||
| based on another non-required buildvariants with only necessary burn-in tasks. |
There was a problem hiding this comment.
[nit] This way we can burn_in on the the requested buildvariant as well other, additional variants to ensure there is no difference between variants.
|
evergreen merge |
ghost
merged commit 
When
--burn-inis passed, only burn_in tasks are generated. Otherwise all the other tasks are generated.