Skip to content

Commit 2c0bebb

Browse files
committed
SERVER-38503 Empty networkMessageCompressors is an error
1 parent df7c2a4 commit 2c0bebb

File tree

4 files changed

+2
-7
lines changed

4 files changed

+2
-7
lines changed

jstests/noPassthrough/compression_options.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,5 @@
3939

4040
runTest("snappy", ["snappy"]);
4141
runTest("disabled", undefined);
42-
runTest("", undefined);
4342

4443
}());

src/mongo/shell/shell_options.cpp

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,8 @@ Status storeMongoShellOptions(const moe::Environment& params,
152152
}
153153

154154
if (params.count("net.compression.compressors")) {
155-
auto compressors = params["net.compression.compressors"].as<string>();
156-
if (compressors != "disabled") {
157-
shellGlobalParams.networkMessageCompressors = std::move(compressors);
158-
}
155+
shellGlobalParams.networkMessageCompressors =
156+
params["net.compression.compressors"].as<string>();
159157
}
160158

161159
if (params.count("nodb")) {

src/mongo/transport/message_compressor_options_client.idl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,5 @@ configs:
3535
source: [ cli, ini, yaml ]
3636
arg_vartype: String
3737
short_name: networkMessageCompressors
38-
implicit: disabled
3938
default: disabled
4039
hidden: true

src/mongo/transport/message_compressor_options_server.idl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,5 +35,4 @@ configs:
3535
source: [ cli, ini, yaml ]
3636
arg_vartype: String
3737
short_name: networkMessageCompressors
38-
implicit: disabled
3938
default: 'snappy,zstd,zlib'

0 commit comments

Comments
 (0)