SERVER-8994: Boost 1.56 build fixes

Author: markbenvenuto

SConstruct

@@ -1551,8 +1551,34 @@ def doConfigure(myenv):
             if using_asan:
                 myenv['ENV']['ASAN_SYMBOLIZER_PATH'] = llvm_symbolizer
 
-    # When using msvc, check for VS 2013 Update 2+ so we can use new compiler flags
+    # When using msvc,
+    # check for min version of VS2013 for fixes in std::list::splice
+    # check for VS 2013 Update 2+ so we can use new compiler flags
     if using_msvc():
+        haveVS2013OrLater = False
+        def CheckVS2013(context):
+            test_body = """
+            #if _MSC_VER < 1800
+            #error Old Version
+            #endif
+            int main(int argc, char* argv[]) {
+            return 0;
+            }
+            """
+            context.Message('Checking for VS 2013 or Later... ')
+            ret = context.TryCompile(textwrap.dedent(test_body), ".cpp")
+            context.Result(ret)
+            return ret
+        conf = Configure(myenv, help=False, custom_tests = {
+            'CheckVS2013' : CheckVS2013,
+        })
+        haveVS2013 = conf.CheckVS2013()
+        conf.Finish()
+
+        if not haveVS2013:
+            print("Visual Studio 2013 RTM or later is required to compile MongoDB.")
+            Exit(1)
+
         haveVS2013Update2OrLater = False
         def CheckVS2013Update2(context):
             test_body = """
@@ -1814,6 +1840,7 @@ def doConfigure(myenv):
     # requires ports devel/libexecinfo to be installed
     if freebsd or openbsd:
         if not conf.CheckLib("execinfo"):
+            print("Cannot find libexecinfo, please install devel/libexecinfo.")
             Exit(1)
 
     # 'tcmalloc' needs to be the last library linked. Please, add new libraries before this 

src/mongo/db/repl/repl_coordinator_impl.h

@@ -29,6 +29,7 @@
 #pragma once
 
 #include <boost/scoped_ptr.hpp>
+#include <boost/thread.hpp>
 #include <boost/thread/mutex.hpp>
 #include <boost/thread/condition_variable.hpp>
 #include <vector>

src/mongo/db/storage/mmap_v1/repair_database.cpp

@@ -373,7 +373,6 @@ namespace mongo {
 
                 Collection* tempCollection = NULL;
                 {
-                    Client::Context tempContext(txn, ns, tempDatabase );
                     WriteUnitOfWork wunit(txn);
                     tempCollection = tempDatabase->createCollection(txn, ns, options, true, false);
                     wunit.commit();
@@ -396,7 +395,6 @@ namespace mongo {
                         indexes.push_back( desc->infoObj() );
                     }
 
-                    Client::Context tempContext(txn, ns, tempDatabase);
                     Status status = indexer.init( indexes );
                     if ( !status.isOK() )
                         return status;
@@ -411,8 +409,6 @@ namespace mongo {
 
                     BSONObj doc = originalCollection->docFor( loc );
 
-                    Client::Context tempContext(txn, ns, tempDatabase);
-                    
                     WriteUnitOfWork wunit(txn);
                     StatusWith<DiskLoc> result = tempCollection->insertDocument(txn,
                                                                                 doc,
@@ -430,7 +426,6 @@ namespace mongo {
                     return status;
 
                 {
-                    Client::Context tempContext(txn, ns, tempDatabase);
                     WriteUnitOfWork wunit(txn);
                     indexer.commit();
                     wunit.commit();

src/mongo/db/storage/record_data.h

@@ -52,7 +52,7 @@ namespace mongo {
         /**
          * Returns true if this owns its own memory, and false otherwise
          */
-        bool isOwned() const { return _dataPtr; }
+        bool isOwned() const { return _dataPtr.get(); }
 
         // TODO eliminate double-copying
         BSONObj toBson() const { return isOwned() ? BSONObj(_data).getOwned() : BSONObj(_data); }

src/mongo/shell/linenoise_utf8.h

@@ -28,6 +28,7 @@
  */
 
 #include <boost/smart_ptr/scoped_array.hpp>
+#include <algorithm>
 #include <string.h>
 
 namespace linenoise_utf8 {

src/mongo/stdx/list.h

@@ -28,23 +28,6 @@
 
 #pragma once
 
-#ifdef _MSC_VER
-
-// The MSVS STL implementation of std::list is not standards compliant, at least because it
-// invalidates iterators during std::list::splice operations.
-
-#include <boost/container/list.hpp>
-
-namespace mongo {
-namespace stdx {
-
-    using boost::container::list;
-
-}  // namespace stdx
-}  // namespace mongo
-
-#else
-
 #include <list>
 
 namespace mongo {
@@ -54,4 +37,4 @@ namespace stdx {
 
 }  // namespace stdx
 }  // namespace mongo
-#endif
+