CLOUDP-339293: Add plugin version check #4160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
reviewed
Aug 25, 2025
internal/plugin/plugin_test.go
Outdated
| assert.Equal(t, plugin.Commands[0].Aliases, manifest.Commands["testCommand"].Aliases) | ||
| } | ||
|
|
||
| func TestPluginVerion(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestPluginVerion(t *testing.T) { | |
| func TestPluginVersion(t *testing.T) { |
blva
reviewed
Aug 25, 2025
| return | ||
| } | ||
| } | ||
| // Disabling this plugin test until atlas-cli-plugin-kubernetes v1.1.7 is released. Will be re-enabled by CLOUDP-340658 |
There was a problem hiding this comment.
[q] should we keep the plugin test running and comment the validation instead until we release?
There was a problem hiding this comment.
Makes sense, modified this ticket which is to be done after changes to k8s plugin to reflect the new approach: CLOUDP-340658
cveticm
commented
Sep 1, 2025
internal/plugin/plugin.go
Outdated
| } | ||
|
|
||
| func (p *Plugin) Run(cmd *cobra.Command, args []string) error { | ||
| // TODO: uncomment after plugin release |
There was a problem hiding this comment.
to be done by CLOUDP-340658
blva
approved these changes
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
PR (2/2) of #4158
For the two plugins effected by the refactor work of the Service Accounts Epic, we need to check if the plugins are a version which supports the new config version.
To address this, I have added a check when running a plugin command which:
Plugin min versions
These versions are the expected versions we will implement support for the refactor work.
plugin refactor work tickets:
Example error: