Skip to content

Conversation

blva
Copy link
Collaborator

@blva blva commented Sep 23, 2025

Proposed changes

Jira ticket: CLOUDP-346295

This is the first PR for this task, adding support for 8.2 first, will try to automate based on atlas local framework in the next PR. I think the 8.2 failures are because we didn't publish yet to 8.2

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added any necessary documentation in document requirements section listed in CONTRIBUTING.md (if appropriate)
  • I have addressed the @mongodb/docs-cloud-team comments (if appropriate)
  • I have updated test/README.md (if an e2e test has been added)
  • I have run make fmt and formatted my code

Further comments

@blva blva marked this pull request as ready for review September 25, 2025 07:41
@blva blva requested a review from a team as a code owner September 25, 2025 07:41
internalMongodPort = 27017
mdb7 = "7.0"
mdb8 = "8.0"
mdb8 = "8.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you update this? According to the lines below, when you pick 8.0 the cli should automatically use 8.2:

Help: "Major MongoDB Version for the deployment. Atlas CLI applies the latest minor version available.",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement is correct for atlas:

cluster.MongoDBMajorVersion = version

But wrong for atlas-local:

return getLocalDevImage() + ":" + opts.MdbVersion

I would recommend updating the function above to something like:

func (opts *DeploymentOpts) MongodDockerImageName() string {
	v, _ := semver.NewVersion(opts.MdbVersion)
	return getLocalDevImage() + ":" + strconv.FormatUint(v.Major(), 10)
}

This works because we publish major versions:
https://hub.docker.com/layers/mongodb/mongodb-atlas-local/8/images/sha256-ad634852e222ca68ae0becdb56ef432c52d87419d4ed041e09d5731a500da784

So when 8.3 becomes available, the tag 8 will point to 8.3

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the details! updating

@blva blva requested a review from a team as a code owner September 25, 2025 12:17
@blva blva requested a review from jeroenvervaeke September 25, 2025 15:11
@blva blva changed the title chore: add MDB 8.2 CLOUDP-346295: add MDB 8.2 Sep 25, 2025
@blva blva merged commit 3bb80d5 into master Sep 26, 2025
29 of 31 checks passed
@blva blva deleted the CLOUDP-346295 branch September 26, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants