-
Notifications
You must be signed in to change notification settings - Fork 88
CLOUDP-346295: add MDB 8.2 #4232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
internal/cli/deployments/setup.go
Outdated
internalMongodPort = 27017 | ||
mdb7 = "7.0" | ||
mdb8 = "8.0" | ||
mdb8 = "8.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you update this? According to the lines below, when you pick 8.0
the cli should automatically use 8.2
:
Help: "Major MongoDB Version for the deployment. Atlas CLI applies the latest minor version available.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The statement is correct for atlas:
cluster.MongoDBMajorVersion = version |
But wrong for atlas-local:
return getLocalDevImage() + ":" + opts.MdbVersion |
I would recommend updating the function above to something like:
func (opts *DeploymentOpts) MongodDockerImageName() string {
v, _ := semver.NewVersion(opts.MdbVersion)
return getLocalDevImage() + ":" + strconv.FormatUint(v.Major(), 10)
}
This works because we publish major versions:
https://hub.docker.com/layers/mongodb/mongodb-atlas-local/8/images/sha256-ad634852e222ca68ae0becdb56ef432c52d87419d4ed041e09d5731a500da784
So when 8.3
becomes available, the tag 8
will point to 8.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for all the details! updating
Proposed changes
Jira ticket: CLOUDP-346295
This is the first PR for this task, adding support for 8.2 first, will try to automate based on atlas local framework in the next PR. I think the 8.2 failures are because we didn't publish yet to 8.2
Checklist
make fmt
and formatted my codeFurther comments