Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sigs.k8s.io/controller-runtime from 0.18.4 to 0.19.0 #1771

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 16, 2024

Bumps sigs.k8s.io/controller-runtime from 0.18.4 to 0.19.0.

Release notes

Sourced from sigs.k8s.io/controller-runtime's releases.

v0.19.0

⚠️ Deprecation Warnings

Please note that admission.Defaulter/Validator have been deprecated in favor of admission.CustomDefaulter/CustomValidator since v0.17 and will be removed with v0.20.

⚠️ Breaking Changes

✨ New Features

  • client: Add WithFieldValidation client (#2860 #2913)
  • controller & webhook: Recover panics per default & add panic metrics (#2905)
  • controllerutil: configure BlockOwnerDeletion when setting OwnerReference (#2847)
  • fake client: Add scale subresource logic (#2855)
  • predicate: Add missing generic version of ResourceVersionChangedPredicate (#2812)
  • setup-envtest: Download binaries from controller-tools releases instead of GCS (#2811)
  • setup-envtest: Publish setup-envtest binaries via release attachments (#2911)
  • workqueue: Add controller label to workqueue metrics (#2895)

🐛 Bug Fixes

  • apiutil.IsGVKNamespaced: Fix namespaced GVK check to use version (#2875)
  • cache: Fix label defaulting of byObject when namespaces are configured (#2805)
  • certwatcher: Recreate watcher if the file is unlinked and replaced (#2893)
  • manager: Fix log in AddMetricsServerExtraHandler (#2874)
  • manager: Quiet context.Canceled errors during shutdown (#2745)
  • manager: Reintroduce AddMetricsServerExtraHandler (#2813)
  • manager.Start: Prevent LeaderElector setup error from being swallowed (#2876)
  • source.Kind: String() should return correct type (#2806)

🌱 Others

  • actions: Add action to approve actions if /ok-to-test is set (#2908)
  • controller: Add dynamic watcher tests (#2881)
  • dependabot: disable go module bumps, bump all actions in a single PR (#2856)
  • verify-modules: Verify go modules are in sync with upstream k/k (#2774)

📖 Additionally, there have been 5 contributions to our documentation. (#2830, #2849, #2863, #2894, #2899, #2910)

Dependencies

Added

  • cel.dev/expr: v0.15.0
  • github.com/antlr4-go/antlr/v4: v4.13.0

... (truncated)

Commits
  • b901db1 Merge pull request #2924 from lucacome/bump-deps
  • 0c7827e Bump k8s.io deps to v1.31.0
  • 9f5afec Merge pull request #2918 from sbueringer/pr-add-skip-name-validation
  • 96e8152 Merge pull request #2921 from kubernetes-sigs/dependabot/github_actions/all-g...
  • 8f5faff 🌱 Bump actions/upload-artifact in the all-github-actions group
  • 89bebe3 Add SkipNameValidation option
  • 7857623 Merge pull request #2911 from sbueringer/pr-publish-setup-envtest
  • fdc8bd7 Merge pull request #2913 from sbueringer/pr-test-cov-field-validation
  • 7dfd3bb Fix WithFieldValidation client
  • e882354 Merge pull request #2908 from sbueringer/pr-approve-action
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
sigs.k8s.io/controller-runtime [>= 0.8.a, < 0.9]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Aug 16, 2024
@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.19.0 branch 3 times, most recently from 235c17b to dc2a5ea Compare August 16, 2024 10:23
@igor-karpukhin igor-karpukhin added the cloud-tests Run expensive Cloud Tests: Integration & E2E label Aug 16, 2024
@igor-karpukhin
Copy link
Collaborator

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.19.0 branch from 1e24123 to 7f41184 Compare August 19, 2024 08:30
@josvazg josvazg added retest Forces basic retesting and removed retest Forces basic retesting labels Aug 20, 2024
@s-urbaniak
Copy link
Collaborator

controller-runtime 0.19 has breaking changes 😞 i need to revisit this one.

@dependabot dependabot bot force-pushed the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.19.0 branch 2 times, most recently from e7d6b32 to 5a98d08 Compare August 21, 2024 08:01
@ako-releaser ako-releaser bot added the retest Forces basic retesting label Aug 21, 2024
Copy link
Contributor

github-actions bot commented Aug 23, 2024

@s-urbaniak s-urbaniak force-pushed the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.19.0 branch from 2c74142 to e450791 Compare August 23, 2024 09:14
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 👍

Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for the surprising removal of RBAC permissions in bulk. PTAL

Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking so that the RBAC review is not forgotten before merging

Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!

@s-urbaniak s-urbaniak merged commit 6fb32b1 into main Aug 23, 2024
58 checks passed
@s-urbaniak s-urbaniak deleted the dependabot/go_modules/sigs.k8s.io/controller-runtime-0.19.0 branch August 23, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cloud-tests Run expensive Cloud Tests: Integration & E2E dependencies Pull requests that update a dependency file go Pull requests that update Go code retest Forces basic retesting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants