-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sigs.k8s.io/controller-runtime from 0.18.4 to 0.19.0 #1771
Bump sigs.k8s.io/controller-runtime from 0.18.4 to 0.19.0 #1771
Conversation
235c17b
to
dc2a5ea
Compare
@dependabot rebase |
1e24123
to
7f41184
Compare
controller-runtime 0.19 has breaking changes 😞 i need to revisit this one. |
e7d6b32
to
5a98d08
Compare
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.18.4 to 0.19.0. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.18.4...v0.19.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
[dependabot skip]
2c74142
to
e450791
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the surprising removal of RBAC permissions in bulk. PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking so that the RBAC review is not forgotten before merging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great fix!
Bumps sigs.k8s.io/controller-runtime from 0.18.4 to 0.19.0.
Release notes
Sourced from sigs.k8s.io/controller-runtime's releases.
... (truncated)
Commits
b901db1
Merge pull request #2924 from lucacome/bump-deps0c7827e
Bump k8s.io deps to v1.31.09f5afec
Merge pull request #2918 from sbueringer/pr-add-skip-name-validation96e8152
Merge pull request #2921 from kubernetes-sigs/dependabot/github_actions/all-g...8f5faff
🌱 Bump actions/upload-artifact in the all-github-actions group89bebe3
Add SkipNameValidation option7857623
Merge pull request #2911 from sbueringer/pr-publish-setup-envtestfdc8bd7
Merge pull request #2913 from sbueringer/pr-test-cov-field-validation7dfd3bb
Fix WithFieldValidation cliente882354
Merge pull request #2908 from sbueringer/pr-approve-actionMost Recent Ignore Conditions Applied to This Pull Request
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)