CLOUDP-81188: fix deletion of Atlas Cluster #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 25, 2021 17:33
vasilevp
approved these changes
Jan 27, 2021
| } | ||
|
|
||
| _, err = client.Clusters.Delete(context.Background(), project.Status.ID, cluster.Name) | ||
| _, err = atlasClient.Clusters.Delete(context.Background(), project.Status.ID, cluster.Spec.Name) |
Co-authored-by: Pavel Vasilev <explosere@gmail.com>
crew-helper
commented
Jan 27, 2021
| ctx := customresource.MarkReconciliationStarted(r.Client, cluster, log) | ||
|
|
||
| log.Infow("-> Starting AtlasCluster reconciliation", "spec", cluster.Spec) | ||
| log.Infow("-> Starting AtlasCluster reconciliation", "spec", cluster.Spec, "generation", cluster.Generation, "status", cluster.Status) |
There was a problem hiding this comment.
@vasilevp this one was added for debugging issue - I expect there are sometimes caching problems and that's why our tests are flaky
crew-helper
commented
Jan 27, 2021
pkg/util/testutil/customresources.go
Outdated
| } | ||
| // Atlas Operator hasn't started working yet | ||
| if createdResource.GetGeneration() != createdResource.GetStatus().GetObservedGeneration() { | ||
| fmt.Printf("Generation: %+v, observed Generation: %+v\n", createdResource.GetGeneration(), createdResource.GetStatus().GetObservedGeneration()) |
There was a problem hiding this comment.
this is also for debugging of flaky tests
leo-ri
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes cluster deletion: uses the
spec.Nameinstead of the resourceName.Also moves the testing logic for cluster deletion to
afterRunto avoid double calls to cluster removal. Then waits until the cluster is removed and removes the project