Skip to content

Fix lost toleration when key duplicated #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2023
Merged

Fix lost toleration when key duplicated #1314

merged 1 commit into from
Jul 3, 2023

Conversation

drivebyer
Copy link
Contributor

All Submissions:

close #1313

  • Have you opened an Issue before filing this PR?
  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if such).

@drivebyer
Copy link
Contributor Author

PTAL @irajdeep @lsierant @mircea-cosbuc

@mircea-cosbuc mircea-cosbuc added the safe-to-test Add this label to PRs from forks to trigger E2E tests label Jun 29, 2023
irajdeep
irajdeep approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@irajdeep irajdeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@irajdeep irajdeep merged commit 7460db3 into mongodb:master Jul 3, 2023
@drivebyer drivebyer deleted the fix_merge_toleration branch July 4, 2023 01:42
@siegenthalerroger siegenthalerroger mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mircea-cosbuc mircea-cosbuc Awaiting requested review from mircea-cosbuc mircea-cosbuc is a code owner

@lsierant lsierant Awaiting requested review from lsierant lsierant is a code owner

@slaskawi slaskawi Awaiting requested review from slaskawi

@nammn nammn Awaiting requested review from nammn nammn is a code owner

1 more reviewer

@irajdeep irajdeep irajdeep approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mircea-cosbuc mircea-cosbuc

Labels
safe-to-test Add this label to PRs from forks to trigger E2E tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect merging of tolerations
3 participants
@drivebyer @irajdeep @mircea-cosbuc