CLOUDP-193669: Make overriden tolerations take precedence #1346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mircea-cosbuc
requested review from
irajdeep,
lsierant,
slaskawi and
nammn
as code owners
slaskawi
approved these changes
Aug 9, 2023
|
@slaskawi The STS override e2e tests were updated to include tolerations. |
lucian-tosa
reviewed
Aug 9, 2023
test/e2e/statefulset_arbitrary_config/statefulset_arbitrary_config_test.go
Show resolved
Hide resolved
|
LGTM |
lucian-tosa
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses a bug where overriding tolerations in the StatefulSet spec would end up in an endless reconciliation loop.
Addresses: