Skip to content

Correct kubectl-mongodb path for command prepare_local_e2e #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025

Conversation

viveksinghggits
Copy link
Contributor

Summary

When we change the directory of kubectl-mongodb from public/tools/multicluster to cmd/kubectl-mongodb we change the source file build_multi_cluster_kubeconfig_creator.sh to use the new path but I missed updating the new path in the file funcs/multicluster. This PR fixes that problem and updates the path to point to the correct location.

Proof of Work

Run make prepare_local_e2e, that will build the kubectl-mongodb binary and use the kubectl mongodb multicluster command to setup the multicluster environment.

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you added changelog file?

@viveksinghggits viveksinghggits requested a review from a team as a code owner August 5, 2025 16:08
@viveksinghggits viveksinghggits added the skip-changelog Use this label in Pull Request to not require new changelog entry file label Aug 5, 2025
Copy link

github-actions bot commented Aug 5, 2025

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.2.1 Release Notes

Other Changes

  • Optional permissions for PersistentVolumeClaim moved to a separate role. When managing the operator with Helm it is possible to disable permissions for PersistentVolumeClaim resources by setting operator.enablePVCResize value to false (true by default). When enabled, previously these permissions were part of the primary operator role. With this change, permissions have a separate role.
  • subresourceEnabled Helm value was removed. This setting used to be true by default and made it possible to exclude subresource permissions from the operator role by specifying false as the value. We are removing this configuration option, making the operator roles always have subresource permissions. This setting was introduced as a temporary solution for this OpenShift issue. The issue has since been resolved and the setting is no longer needed.

@viveksinghggits
Copy link
Contributor Author

The CI is failing because of a known issue https://mongodb.slack.com/archives/CGLP6R2PQ/p1753439731022119?thread_ts=1753361900.361289&cid=CGLP6R2PQ, and it's recommended to ignore the failure in the CI. I will go ahead and merge the PR.

@viveksinghggits viveksinghggits merged commit b29fb4a into master Aug 6, 2025
35 of 39 checks passed
@viveksinghggits viveksinghggits deleted the kubectl-mongodb-prepare-local-e2e branch August 6, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Use this label in Pull Request to not require new changelog entry file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants