Multi refactoring arch #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nammn
requested review from
m1kola,
MaciejKaras and
lucian-tosa
and removed request for
a team
lucian-tosa
requested changes
Aug 20, 2025
build_info.json
Outdated
Comment on lines
24
to
25
| "platforms": [ | ||
| "linux/arm64", | ||
| "linux/amd64", | ||
| "linux/s390x", | ||
| "linux/ppc64le" | ||
| "linux/amd64" |
There was a problem hiding this comment.
why remove the platforms from the release stage?
There was a problem hiding this comment.
accident! Let me add it back
build_info_agent.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "platform_mappings": { | |||
| "platforms": { | |||
| "linux/amd64": { | |||
| "agent_suffixes": ["linux_x86_64.tar.gz"], | |||
| "tools_suffix": "rhel93-x86_64-{TOOLS_VERSION}.tgz", | |||
There was a problem hiding this comment.
should we have an array of suffixes for tools as well?
There was a problem hiding this comment.
hmmmm yeah probably cleaner, let me do so
lucian-tosa
requested changes
Aug 20, 2025
build_info.json
Outdated
Comment on lines
119
to
122
| "linux/arm64", | ||
| "linux/amd64", | ||
| "linux/s390x", | ||
| "linux/ppc64le" |
There was a problem hiding this comment.
OM is not built for these platforms, the init image doesn't need to be
There was a problem hiding this comment.
we don't lose anything by doing so - i would just add them as this streamlines all the binaries we own
There was a problem hiding this comment.
There was a problem hiding this comment.
oh - they are close to timeout limit. I do wonder why. Yeah I can kick it off
build_info.json
Outdated
Comment on lines
129
to
132
| "linux/arm64", | ||
| "linux/amd64", | ||
| "linux/s390x", | ||
| "linux/ppc64le" |
lucian-tosa
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request refactors the agent build and validation logic to improve multi-architecture support and maintainability. It centralizes platform mapping logic, simplifies platform-specific filename resolution, and updates configuration files to reflect platform support changes. Additionally, it documents the new multi-architecture capabilities in the changelog.
Multi-architecture support and configuration updates:
build_info.jsonto restrict supported platforms for all images to onlylinux/amd64, removingarm64,s390x, andppc64lefrom all relevant entries. [1] [2] [3] [4] [5] [6] [7] [8]build_info_agent.jsonfromplatform_mappingstoplatformsfor consistency and clarity.Agent build and validation code refactoring:
PlatformConfigurationclass invalidation.pyto encapsulate platform mapping logic, lazy-load build info, and provide unified methods for generating agent and tools build arguments.platformskey and centralized filename resolution logic, including helper methods for finding valid filenames and checking URL existence. [1] [2] [3] [4] [5]atomic_pipeline.pyto use the new build argument generation functions from the refactored validation logic. [1] [2]atomic_pipeline.py.Documentation:
Proof of Work
Checklist
skip-changeloglabel if not needed