-
Notifications
You must be signed in to change notification settings - Fork 17
[CLOUDP-341578] Update client-go and related module to version to v0.31.11
#370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MCK 1.3.0 Release NotesNew FeaturesMulti-Architecture SupportWe've added comprehensive multi-architecture support for the kubernetes operator. This enhancement enables deployment on IBM Power (ppc64le) and IBM Z (s390x) architectures alongside Bug Fixes
Other Changes
|
894a1a2
to
edeac62
Compare
aac6ffe
to
2c0e62c
Compare
@viveksinghggits I think that it makes sense to add a ticket for this |
Sure, I will create and link the ticket Anand. |
v0.31.11
v0.31.11
After updating the k8s.io related mods when we tried to generate the manifests using make manifests it failed with ``` /Users/vivek.s/go/pkg/mod/k8s.io/api@v0.31.11/core/v1/doc.go:21:1: missing argument "" (at <input>) /Users/vivek.s/go/pkg/mod/k8s.io/api@v0.31.11/core/v1/doc.go:21:1: missing argument "" (at <input>) k8s.io/api/core/v1:-: unknown type "k8s.io/api/core/v1".LocalObjectReference ``` and other similar issues. It simply meant that the controller-gen version is not compatible with the k8s.io/api version that we have upgraded it to. That's why this commit updates the controller-gen version to 0.18.0.
dc80ac2
to
a25fb69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.34 was released last week, this means that the lowest version we support is now 1.32. Should we update the libraries again?
Based on our versioning policy (https://wiki.corp.mongodb.com/spaces/MMS/pages/193108905/Kubernetes+Operators+Versioning), we don't support 1.34 yet. We can only start supporting 2m after release, thus we don't need to change it again in this PR. |
"All three Operators (AKO, MCO and MEKO) aim to provide support for the latest Kubernetes release as the highest supported version, as long as that version of Kubernetes is released 2 months or more ahead of the release of an Operator version." "The lowest supported Kubernetes version is 2 versions below the highest supported version. I.e. if the highest supported Kubernetes version is 1.29, then the lowest supported version is 1.29-2 = 1.27." If I understood these two statements from the document https://wiki.corp.mongodb.com/spaces/MMS/pages/193108905/Kubernetes+Operators+Versioning correctly, it means that we (MCK) don't necessarily have to support a K8s version as soon as it's released. It's ok to have the K8s version that was released 2 months back (let's say x) as latest supported version of my MCK. And then x-2 would be the least supported version. I raised the PR considering above statements, but I was a little confused and that's why I commented here https://docs.google.com/document/d/1eJ8iKsI0libbpcJakGjxcPfbrTn8lmcZDbQH1UqMR_g/edit?disco=AAABp7ADmA4, but we can change the module version to |
I didn't notice, @mircea-cosbuc's comment. And I think said the same thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got it, thanks
Summary
As part of the release process we are planning to upgrade the client-go version to
0.31.11
. This PR does that. Just updating the client-go results into a compatibility issue withcontroller-runtime
,that's why we are also updating
controller-runtime
to newer version (v0.19.4
).Updating controller-runtime was a breaking because most of the utilities now are typed (using generics) that why we had to make respective go file changes.
Proof of Work
Running
go build
in the root of the repo works, that makes sure that we are able to build the binary. Apart from that I also rango test
in the dirs where I am changing the test files and that worked as well.Checklist
skip-changelog
label if not needed