Skip to content

CLOUDP-346604: fixes for search snippets after 1.4.0 #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 30, 2025
Merged

CLOUDP-346604: fixes for search snippets after 1.4.0 #472

merged 3 commits into from
Sep 30, 2025

Conversation

lsierant
Copy link
Contributor

@lsierant lsierant commented Sep 24, 2025 •
edited
Loading

Summary

This PR fixes search snippets issued found after the release 1.4.0

Proof of Work

Passing search snippets tests: evg link

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you added changelog file?

@lsierant lsierant requested a review from a team as a code owner September 24, 2025 09:40
@lsierant lsierant changed the title Lsierant/search snippets fixes 1.4.0 CLOUDP-346604: fixes for search snippets after 1.4.0 Sep 24, 2025
@lsierant lsierant force-pushed the lsierant/search-snippets-fixes-1.4.0 branch from ccc7e60 to 7759c5a Compare September 24, 2025 09:41
@github-actions GitHub Actions
Copy link

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.4.1 Release Notes

lsierant
lsierant commented Sep 24, 2025
View reviewed changes
docs/search/02-search-enterprise-deploy/output/02_0090_helm_add_mogodb_repo.out Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those outputs should be removed as we moved them under scripts/code_snippets/tests

Also we'll stop comitting outputs to MCK repo at all soon.

@lsierant lsierant force-pushed the lsierant/search-snippets-fixes-1.4.0 branch from 7759c5a to 4ab5213 Compare September 24, 2025 18:45
@lsierant lsierant force-pushed the lsierant/search-snippets-fixes-1.4.0 branch from 4ab5213 to aecec3e Compare September 25, 2025 07:34
@lsierant lsierant added the skip-changelog Use this label in Pull Request to not require new changelog entry file label Sep 25, 2025
@lsierant lsierant mentioned this pull request Sep 25, 2025
Open
3 tasks
mircea-cosbuc
mircea-cosbuc reviewed Sep 25, 2025
View reviewed changes
Copy link
Member

@mircea-cosbuc mircea-cosbuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does a lot more than changing the secret creation. Please describe the extent of the fixes. For example it's not clear how this addresses fixing the syncing/backporting process. Is it through removing output files?

@lsierant lsierant merged commit 917723b into master Sep 30, 2025
37 of 38 checks passed
@lsierant lsierant deleted the lsierant/search-snippets-fixes-1.4.0 branch September 30, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fealebenpae fealebenpae fealebenpae approved these changes

@mircea-cosbuc mircea-cosbuc mircea-cosbuc approved these changes

@lucian-tosa lucian-tosa lucian-tosa approved these changes

Assignees

No one assigned

Labels

skip-changelog Use this label in Pull Request to not require new changelog entry file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lsierant @fealebenpae @mircea-cosbuc @lucian-tosa