Fix private_gke_code_snippets + other small fixes

[MaciejKaras]

Summary

This PR fixes private_gke_code_snippets tests that could not properly set the context:

scripts/dev/contexts/private_gke_code_snippets: line 13: /data/mci/33f77d5e70bc4d8e19bb3f674e0743b1/src/github.com/mongodb/mongodb-kubernetes/scripts/dev/contexts/variables/funcs/gke: No such file or directory

The reason was om80 context file replaced the script_dir variable that was also set and used in private_gke_code_snippets. After that the script_dir pointed to ./scripts/dev/contexts/variables instead of ./scripts/dev/contexts/ and the gke script could not be found. The solution was to replace script_dir usage in om80 script with PROJECT_DIR. It was also replaced in other scripts which had long path based on script_dir.

The other thing that was fixed is switch_context function. Previously because we concatenated result from multiple bash commands, we didn't consume the error code from actual command:

      script: |
        echo "Switching context"
        scripts/dev/switch_context.sh "${build_variant}"
        echo "Finished switching context"

Proof of Work

Passing CI + manual patch for private_gke_code_snippets .

Checklist

• Have you linked a jira ticket and/or is the ticket in the title?
• Have you checked whether your jira ticket required DOCSP changes?
• Have you added changelog file?
  • use skip-changelog label if not needed
  • refer to Changelog files and Release Notes section in CONTRIBUTING.md for more details

[github-actions]

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.4.1 Release Notes

[lsierant]

this is not necessary as the file is only sourced, not executed directly

[MaciejKaras]

True! At the same time it helps mark the file in IDE as bash script ;)

[m1kola]

True! At the same time it helps mark the file in IDE as bash script ;)

Not requesting to change this. Just joining the chat :)

From my experience adding a shebang is usually enough for IDEs.

[MaciejKaras]

Yeah, I thought that Łukasz commented all added lines. But I agree pipefail is not needed, but also harmless ;)

[m1kola]

True! At the same time it helps mark the file in IDE as bash script ;)

Not requesting to change this. Just joining the chat :)

From my experience adding a shebang is usually enough for IDEs.

[m1kola]

Not something for this PR, but I think we should switch for yq/jq for reading yaml/json instead of awk.