Skip to content

Conversation

anandsyncs
Copy link
Contributor

@anandsyncs anandsyncs commented Sep 30, 2025

Summary

This pull request updates the configuration and code snippets for setting up an external MongoDB Search service to improve clarity and consistency in variable naming. The main change is the introduction of the MDB_SEARCH_SERVICE_NAME variable, replacing the previous use of MDB_SEARCH_HOSTNAME for Kubernetes service references, while MDB_SEARCH_HOSTNAME is now used specifically for the DNS hostname.

Configuration variable updates:

  • Introduced MDB_SEARCH_SERVICE_NAME to represent the Kubernetes service name and updated all related references in env_variables.sh and README.md. The MDB_SEARCH_HOSTNAME variable is now used to specify the DNS hostname (e.g., mdbs-search.example.com). [1] [2]

Kubernetes service creation and referencing:

  • Updated service creation in 04_0322_create_search_loadbalancer_service.sh to use MDB_SEARCH_SERVICE_NAME for the service name instead of MDB_SEARCH_HOSTNAME.
  • Changed all kubectl commands and log messages in scripts to reference MDB_SEARCH_SERVICE_NAME instead of MDB_SEARCH_HOSTNAME, ensuring consistency throughout the deployment process. [1] [2]

Proof of Work

Snippet tests pass

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you added changelog file?

@anandsyncs anandsyncs changed the title WIP: clarify variable name WIP: clarify host name Sep 30, 2025
Copy link

⚠️ (this preview might not be accurate if the PR is not rebased on current master branch)

MCK 1.5.0 Release Notes

New Features

  • Improve automation agent certificate rotation: the agent now restarts automatically when its certificate is renewed, ensuring smooth operation without manual intervention and allowing seamless certificate updates without requiring manual Pod restarts.

@anandsyncs anandsyncs added the skip-changelog Use this label in Pull Request to not require new changelog entry file label Oct 1, 2025
@anandsyncs anandsyncs changed the title WIP: clarify host name Clarify hostname and service name in external mongod search snippets Oct 1, 2025
@anandsyncs anandsyncs marked this pull request as ready for review October 1, 2025 12:59
@anandsyncs anandsyncs requested a review from a team as a code owner October 1, 2025 12:59
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably remove that readme completely?

@anandsyncs anandsyncs merged commit 12f405a into master Oct 5, 2025
35 of 37 checks passed
@anandsyncs anandsyncs deleted the anandsyncs/update-external-search-snippet branch October 5, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Use this label in Pull Request to not require new changelog entry file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants