MONGOID-4524 Combine options when nesting PersistenceContexts on the same object #4608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
changed the title
p-mongo
changed the title
saghm
approved these changes
Feb 5, 2019
saghm
reviewed
Feb 5, 2019
| end | ||
| new_options = existing_options.merge(options_or_context) | ||
| context = PersistenceContext.new(object, new_options) | ||
| Thread.current[key] = context |
There was a problem hiding this comment.
Out of curiosity, will this cause issues if there's more code after the inner block within the outer block? e.g.
Band.with(collection: "artists") do |klass|
Band.with(client: :reports) do |klass|
klass.new.collection_name
end
klass.new.collection_name
endThere was a problem hiding this comment.
Yes, repaired this as well.
saghm
approved these changes
Feb 6, 2019
p-mongo
added a commit
that referenced
this pull request
Feb 6, 2019
…same object (#4608) * MONGOID-4524 Combine options when nesting PersistenceContexts on the same object * Restore persistence context when leaving with block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.