MONGOID-5509 Fix deprecation logic broken on Ruby <= 2.7 on 8.1-stable branch #5572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnyshields
changed the title
|
@jamis can you merge in this one? My "Deprecation" feature is actually broken (does nothing) on Ruby 2.6 and 2.7 given differences of how Module#prepend works. |
jamis
changed the title
|
Good catch, @johnnyshields -- thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes deprecation warning logic to work correctly on Ruby 2.7 and earlier. PR #5489 didn't support it correctly for Ruby <= 2.7, and as a result Ruby 2.7/2.6 specs are failing on
8.1-stablebranch.As you can see in the PR, there are differences in Ruby 2.7 and earlier handle
Module#prependon modules. I've intentionally done if/else for the different Ruby versions so it will be easy to cleanup in the future.