Remove duplicate Cursor constructor #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now only the exported Cursor constructor is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request to fix NODE-246.
scope.jshad its ownCursorconstructor which was used instead of the exposedrequire('mongo').Cursorexample. This caused problems with people who wanted to promisify their cursors.This pull request removes the duplicate constructor and adds a
cloneWithOptionsstatic method to the remainingCursorconstructor. This also improves efficiency (the duplicate constructor set properties on itself on every construction instead of utilizing the prototype chain) and removes a global leak which was present in the duplicate constructor.There is also a new test to verify that the cursors returned are instances of the exposed
Cursorconstructor.