fix: correct typeof check in checkSupportedServer #2690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
referenced
this pull request
Jan 11, 2021
MongoOptions introduce a well typed HostAddress type that tracks the correct shape of a host's address depending on its type. The MongoClientOptions type inherit from node's TLS and Socket options and use our allow list of options to maintain a connection between the types and programmatic processing of options. The hierarchy of options from MongoClient > Topology > Server > ConnectionPool > Connection have been corrected and clarified for responsibilities. NODE-2704
emadum
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This made it passed testing because if maxWireVersion is a number then so is min and the actual 'less than' comparison is correct.