Skip to content

Conversation

nbbeeken
Copy link
Contributor

Some patches and updates to make our v4 API docs generate correctly

The toc setting in typedoc.json limits the symbols that appear on the side bar to only those listed, however all symbols are still available to view when clicking into the exported section. I selected a set of the most commonly used APIs, let me know if we should include something else.

Updated the readme a bit, removing some of the old links and updating the examples.

@nbbeeken
Copy link
Contributor Author

Here's a look at the landing page:

image

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nbbeeken
Copy link
Contributor Author

Sorry for the change after approvals, I just added MongoClientOptions to the list of quick access symbols.

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbbeeken nbbeeken merged commit de06784 into master Jan 14, 2021
@nbbeeken nbbeeken deleted the docs/v4 branch January 14, 2021 20:15
@mbroadst
Copy link
Member

Yikes, sorry I was getting around to this review @nbbeeken. I was wondering if it's possible to use categorizeByGroup to split the API between things like BSON, Errors and . Also can we enable the search? I just want to make it incredibly easy to navigate this documentation, and my guess is that most of the time people either want to quickly drill down with a search or view MongoClient/Db/Collection.

Also, FWIW the old docs include documentation for CSFLE things (like AutoEncrypter)

@nbbeeken
Copy link
Contributor Author

No worries, sorry for merging without your review, luckily search already is working out of the box so thats nice!

The categorize by group requires a bit more effort, which I totally think we should do but I would suggest we move to another PR anyway for diff reasons. We have to sweep over all the tsdoc comments and add in @category annotations

Made a ticket for this: NODE-3005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants