feat(ci): add mongosh integration testing #2698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of NODE-2940.
|
I'm personally ok with going against master as we will find issues immediately rather than waiting for an official release. But I'm also willing to defer to other opinions. |
nbbeeken
approved these changes
Jan 15, 2021
emadum
approved these changes
Jan 15, 2021
|
Fwiw, the failure on its first waterfall run is because of such a breaking change that happened here since I opened the PR :) As mentioned, that will happen from time to time, but I’ll do my best to keep up to date with changes (and try to figure out if there’s a way to get evergreen notifications for failures of specific build variants). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of NODE-2940 (it doesn’t address Compass integration, because I don’t know what that would even look like given the many, many packages that make up Compass).
Add a mongosh integration test task to evergreen. This currently passes CI, but could fail if more breaking changes are being added. I’m doing my best to keep up with all driver changes, but we still have to adjust our code on a regular basis to changes being made to the master branch here – if you want to avoid this task failing occasionally, you can of course wait until the actual 4.0 release (or until all planned breaking changes are done).