Skip to content

fix(NODE-3311): Fix "session" typescript typing for "insertOne" options. #2816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2021
Merged

fix(NODE-3311): Fix "session" typescript typing for "insertOne" options. #2816

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/operations/insert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { MongoError } from '../error';
import { defineAspects, Aspect, AbstractOperation } from './operation';
import { CommandOperation } from './command';
import { CommandOperation, CommandOperationOptions } from './command';
import { prepareDocs } from './common_functions';
import type { Callback, MongoDBNamespace } from '../utils';
import type { Server } from '../sdam/server';
import type { Collection } from '../collection';
import type { Document, BSONSerializeOptions } from '../bson';
import type { Document } from '../bson';
import type { BulkWriteOptions } from '../bulk/common';
import { WriteConcern, WriteConcernOptions } from '../write_concern';
import { WriteConcern } from '../write_concern';
import type { ClientSession } from '../sessions';
import { BulkWriteOperation } from './bulk_write';
import type { InferIdType } from '../mongo_types';
Expand Down Expand Up @@ -46,7 +46,7 @@ export class InsertOperation extends CommandOperation<Document> {
}

/** @public */
export interface InsertOneOptions extends BSONSerializeOptions, WriteConcernOptions {
export interface InsertOneOptions extends CommandOperationOptions {
/** Allow driver to bypass schema validation in MongoDB 3.2 or higher. */
bypassDocumentValidation?: boolean;
/** Force server to assign _id values instead of driver. */
Expand Down