test(NODE-3297): translate community typings tests to tsd format #2822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nbbeeken
commented
May 26, 2021
nbbeeken
commented
- Tests from DefinitelyTyped included in our testing
- Corrections to our types to bring us in sync with the community
- list of the tests that break due to desired drivers changes
nbbeeken
force-pushed
the
NODE-3297/type-tests
branch
from
3a63739 to
dbb1d19
Compare
nbbeeken
requested review from
a team,
dariakp,
durran and
emadum
and removed request for
a team
emadum
reviewed
May 28, 2021
There was a problem hiding this comment.
There are some forgotten export errors in the lint:
Error: src/collection.ts:1123:3 - (ae-forgotten-export) The symbol "FlattenIfArray" needs to be exported by the entry point index.d.ts
Error: src/cursor/find_cursor.ts:341:3 - (ae-forgotten-export) The symbol "SchemaMember" needs to be exported by the entry point index.d.ts
Error: src/mongo_types.ts:45:1 - (ae-forgotten-export) The symbol "Condition" needs to be exported by the entry point index.d.ts
Error: src/mongo_types.ts:45:1 - (ae-forgotten-export) The symbol "RootFilterOperators" needs to be exported by the entry point index.d.ts
7ff4702 to
6710435
Compare
nbbeeken
force-pushed
the
NODE-3297/type-tests
branch
from
f8f8d44 to
28ce0a9
Compare
dariakp
reviewed
Jun 8, 2021
dariakp
reviewed
Jun 9, 2021
dariakp
reviewed
Jun 9, 2021
dariakp
reviewed
Jun 9, 2021
nbbeeken
force-pushed
the
NODE-3297/type-tests
branch
from
640876b to
b83a6ac
Compare
dariakp
approved these changes
Jun 9, 2021
durran
requested changes
Jun 10, 2021
| $bitsAllClear?: BitwiseFilter; | ||
| $bitsAllSet?: BitwiseFilter; | ||
| $bitsAnyClear?: BitwiseFilter; | ||
| $bitsAnySet?: BitwiseFilter; |
There was a problem hiding this comment.
Just missing $rand that is an empty document if we want to be fully complete in this list.
There was a problem hiding this comment.
thanks for catching it, added
| /** | ||
| * (Pre)allocated space for the collection in bytes. | ||
| */ | ||
| storageSize: number; |
There was a problem hiding this comment.
Add freeStorageSize, indexBuilds, totalSize, scaleFactor here as well?
- Tests from DefinitelyTyped included in our testing - Corrections to our types to bring us in sync with the community - list of the tests that break due to desired drivers changes
nbbeeken
force-pushed
the
NODE-3297/type-tests
branch
from
be9fe52 to
f90a10a
Compare
dariakp
requested changes
Jun 14, 2021
| const name = connectionString.indexOf('mongodb+srv') >= 0 ? 'mongodb+srv' : 'normal'; | ||
| it(`${name}`, makeConnectionTest(connectionString)); | ||
| it(`${name}`, function () { | ||
| if (SKIP_TESTS.include(configName)) this.skip(); |
dariakp
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.